On 23/09/19 18:00, Richard Henderson wrote: > On 9/23/19 2:45 AM, Paolo Bonzini wrote: >> On 22/09/19 05:54, Richard Henderson wrote: >>> +/* >>> + * Forced inlining may be desired to encourage constant propagation >>> + * of function parameters. However, it can also make debugging harder, >>> + * so disable it for a non-optimizing build. >>> + */ >>> +#if defined(__OPTIMIZE__) && __has_attribute(always_inline) >>> +#define QEMU_ALWAYS_INLINE __attribute__((always_inline)) >> >> GCC doesn't have __has_attribute, does it? > > It does, since at least gcc 5. And now I realize that's only a reorganization > of the support and not when it was introduced.
Hmm, still we support 4.8 and always_inline is much older than that. So I'm not sure it's useful to test it. Paolo