On Fri, 20 Sep 2019 at 13:27, Eric Blake <ebl...@redhat.com> wrote: > > On 9/19/19 10:59 AM, Peter Maydell wrote: > > In commit 27a296fce9821e we switched the qemu-ga manpage over to > > being built from Sphinx. The makefile rules for this were correct > > for an out-of-tree build, but break for in-tree builds if Sphinx is > > present and we're trying to build the documentation. > > > > > Fix this by using $(MANUAL_BUILDDIR) when constructing the > > list of DOCS files we want to build and also in the source > > file name we install for 'make install'. > > > > (Among other things, this broke the Shippable CI builds.) > > > > Reported-by: Eric Blake <ebl...@redhat.com> > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > --- > > Makefile | 26 +++++++++++++------------- > > 1 file changed, 13 insertions(+), 13 deletions(-) > > Tested in-tree builds both with and without sphinx installed: > > Tested-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks; applied patch to master as a buildfix. -- PMM