On Thu, 19 Sep 2019 at 05:52, Cédric Le Goater <c...@kaod.org> wrote: > > Signed-off-by: Cédric Le Goater <c...@kaod.org> > --- > hw/arm/aspeed.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index 52993f84b461..4450e71e5547 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -88,6 +88,9 @@ struct AspeedBoardState { > /* Witherspoon hardware value: 0xF10AD216 (but use romulus definition) */ > #define WITHERSPOON_BMC_HW_STRAP1 ROMULUS_BMC_HW_STRAP1 > > +/* AST2600 evb hardware value: (QEMU prototype) */ > +#define AST2600_EVB_HW_STRAP1 AST2500_EVB_HW_STRAP1
We can change this to be the actual values if you want: STRAP1: 0x000000C0 STRAP2: 0x00000003 > + .name = MACHINE_TYPE_NAME("ast2600-evb"), > + .desc = "Aspeed AST2600 EVB (Cortex A7)", > + .soc_name = "ast2600-a0", > + .hw_strap1 = AST2600_EVB_HW_STRAP1, > + .fmc_model = "mx25l25635e", > + .spi_model = "mx25l25635e", > + .num_cs = 1, > + .i2c_init = ast2600_evb_i2c_init, Can we add a default ram size? mc->default_ram_size = 2 * GiB; With these two fixed: Reviewed-by: Joel Stanley <j...@jms.id.au> Cheers, Joel