On Wed, Sep 18, 2019 at 11:19:33PM +0000, Oleinik, Alexander wrote: > Signed-off-by: Alexander Oleinik <alx...@bu.edu> > --- > configure | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/configure b/configure > index 30aad233d1..775f46f55a 100755 > --- a/configure > +++ b/configure > @@ -498,6 +498,7 @@ libxml2="" > debug_mutex="no" > libpmem="" > default_devices="yes" > +fuzzing="no" > > supported_cpu="no" > supported_os="no" > @@ -1521,6 +1522,8 @@ for opt do > ;; > --disable-libpmem) libpmem=no > ;; > + --enable-fuzzing) fuzzing=yes > + ;;
Please add --disable-fuzzing, the ./configure script says: # Always add --enable-foo and --disable-foo command line args. > *) > echo "ERROR: unknown option $opt" > echo "Try '$0 --help' for more information" > @@ -6429,6 +6432,7 @@ echo "capstone $capstone" > echo "libpmem support $libpmem" > echo "libudev $libudev" > echo "default devices $default_devices" > +echo "fuzzing support $fuzzing" > > if test "$supported_cpu" = "no"; then > echo > @@ -7258,6 +7262,10 @@ fi > if test "$sheepdog" = "yes" ; then > echo "CONFIG_SHEEPDOG=y" >> $config_host_mak > fi > +if test "$fuzzing" = "yes" ; then > + FUZZ_LDFLAGS=" -fsanitize=address,fuzzer" > + FUZZ_CFLAGS=" -fsanitize=address,fuzzer" > +fi Is -fsanitize=fuzzer a clang-only option? If yes, then please ensure that there is a friendly error message when ./configure is run with gcc. You could probe if -fsanitize=fuzzer works and then check that fuzzing=no when this feature is unavailable.
signature.asc
Description: PGP signature