On 12/09/2019 16:30, Greg Kurz wrote: > Unless the machine was started with kernel-irqchip=on, we cannot easily > tell if we're actually using an in-kernel or an emulated irqchip. This > information is important enough that it is worth printing it in 'info > pic'.
Nice ! > Signed-off-by: Greg Kurz <gr...@kaod.org> Reviewed-by: Cédric Le Goater <c...@kaod.org> Thanks, C. > --- > hw/ppc/spapr.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 761f8214c312..348c007ffbd3 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -81,6 +81,8 @@ > #include "hw/mem/memory-device.h" > #include "hw/ppc/spapr_tpm_proxy.h" > > +#include "monitor/monitor.h" > + > #include <libfdt.h> > > /* SLOF memory layout: > @@ -4360,6 +4362,8 @@ static void spapr_pic_print_info(InterruptStatsProvider > *obj, > SpaprMachineState *spapr = SPAPR_MACHINE(obj); > > spapr->irq->print_info(spapr, mon); > + monitor_printf(mon, "irqchip: %s\n", > + kvm_irqchip_in_kernel() ? "in-kernel" : "emulated"); > } > > int spapr_get_vcpu_id(PowerPCCPU *cpu) >