On Wed, Sep 04, 2019 at 04:51:21PM +0100, Stefan Hajnoczi wrote: > On Tue, Sep 03, 2019 at 06:26:44PM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > Add the --print-capabilities option as per vhost-user.rst "Backend > > > programs conventions". Currently there are no advertised features. > > > > > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > > > That looks OK to me, but can someone who understands the json > > requirement explain what says whether a 'features' entry is optional? > > I have defined a VHostUserBackendType ('fs') but no > VHostUserBackendCapabilities union field. > > I guess this is allowed since many other VIRTIO device types are also > defined without a VHostUserBackendCapabilities union field (only 'gpu' > and 'input' have one).
Hi Marc-André, Please review when you have time. You are the vhost-user.json expert :). Stefan
signature.asc
Description: PGP signature