On Fri, 2019-09-06 at 14:59 +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 30, 2019 at 11:56:02PM +0300, Maxim Levitsky wrote:
>
> This could do with some text to explain what this will be
> used for.
I actually added an explanation to the man page
"
+--force allows some unsafe operations. Currently for -f luks,
+it allows to erase last encryption key, and to overwrite an active
+encryption key.
+
"
You probably mean adding few words in the commit message as well,
and I'll do that anyway.
>
> > Signed-off-by: Maxim Levitsky <mlevi...@redhat.com>
> > ---
> > block.c | 4 +++-
> > block/qcow2.c | 1 +
> > include/block/block.h | 1 +
> > include/block/block_int.h | 1 +
> > qemu-img-cmds.hx | 4 ++--
> > qemu-img.c | 8 +++++++-
> > qemu-img.texi | 6 +++++-
> > 7 files changed, 20 insertions(+), 5 deletions(-)
>
> For the code
>
> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
>
>
> Regards,
> Daniel
Best regards,
Maxim Levitsky
