On Thu, 12 Sep 2019 at 09:57, Auger Eric <eric.au...@redhat.com> wrote: > > Hi Peter, > On 9/12/19 10:42 AM, Peter Maydell wrote:
> > Is there really no place to put this check in common code? > Not sure what you mean by common code here? Do you mean in a common code > for ARM machines (I don't think we have any atm) or directly in > kvm_init(). I did not want to pollute this latter with this ARM specific > fix. I'd just rather we didn't have to have the same "if ..." check in every arm board that supports KVM. If kvm_init() happens at a point where we have enough info to make the check, then you can put the check in kvm_arch_init(), which is the architecture-specific hook that kvm_init() calls. thanks -- PMM
