On Fri, 6 Sep 2019 at 21:26, Alex Bennée <alex.ben...@linaro.org> wrote: > > Hi Peter, > > Hopefully this is the final version of the semihosting at translate > time patches. I've applied Richard's IS_USER changes and gated the SVN > for !M profile. > > Alex Bennée (3): > target/arm: handle M-profile semihosting at translate time > target/arm: handle A-profile semihosting at translate time > target/arm: remove run time semihosting checks
Hi. I've just been looking at these, and I noticed that they seem to accidentally extend the "no semihosting in user mode" check that is currently for softmmu only to also cover linux-user mode (where it would amount to "never provide semihosting"). This is because we used to do the check in the helper.c code which is only used by softmmu, and not in the linux-user/arm/cpu_loop.c equivalent that linux-user uses. But now we do the check in translate.c, which is common to both. There's also some missed cleanup in that the linux-user code can also have the "maybe EXCP_BKPT/EXCP_SWI is a semihosting call" checks deleted. > Emilio G. Cota (1): > atomic_template: fix indentation in GEN_ATOMIC_HELPER I've taken the atomic_template fix into target-arm.next, since it's unrelated. thanks -- PMM
