On 9/10/19 1:37 AM, Markus Armbruster wrote: > A union or alternate without branches makes no sense and doesn't work: > it can't be instantiated. A union or alternate with just one branch > works, but is degenerate. We accept the former, but reject the > latter. Weird. docs/devel/qapi-code-gen.txt doesn't mention the > difference. It claims an alternate definition is "is similar to a > simple union type". > > Permit degenerate alternates to make them consistent with unions. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > scripts/qapi/common.py | 6 ++---- > tests/qapi-schema/alternate-empty.err | 2 +- > tests/qapi-schema/alternate-empty.json | 4 ++-- > tests/qapi-schema/qapi-schema-test.json | 4 +++- > tests/qapi-schema/qapi-schema-test.out | 6 ++++-- > 5 files changed, 12 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> (Might make sense if one of the branches is conditional, where depending on compile-time options it could be a two-branch or a one-branch alternate) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
