Am 18.05.2011 09:57, schrieb Stefan Hajnoczi: > On Wed, May 18, 2011 at 7:55 AM, Dmitry Konishchev <konishc...@gmail.com> > wrote: >> So, if you are agreed with the said above, you can accept this patch >> and then I'll write an enchancement for it with bdrv_is_allocated() >> because it is going to include this patch. > > Yes, optimizing is_not_zero() is good. The only additional thing I > suggest is adding a comment before the function to document the length > constraint. > > Kevin Wolf is CCed, he's the QEMU block layer maintainer and may have > additional thoughts before accepting this patch.
For this one not really. Except for the coding style it looks good to me. A future bdrv_is_allocated() patch must make sure that the conversion falls back to a simple is_not_zero() when a backing file is used. Kevin
