We are returning unintialized memory, this is probably unsafe.
Reported-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
hw/misc/bcm2835_property.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index d86d510572..399f0d9dd5 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -57,6 +57,7 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState
*s, uint32_t value)
case 0x00010001: /* Get board model */
qemu_log_mask(LOG_UNIMP,
"bcm2835_property: %x get board model NYI\n", tag);
+ /* FIXME returning uninitialized memory */
resplen = 4;
break;
case 0x00010002: /* Get board revision */
@@ -70,6 +71,7 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState
*s, uint32_t value)
case 0x00010004: /* Get board serial */
qemu_log_mask(LOG_UNIMP,
"bcm2835_property: %x get board serial NYI\n", tag);
+ /* FIXME returning uninitialized memory */
resplen = 8;
break;
case 0x00010005: /* Get ARM memory */
--
2.20.1
