On Tue, Sep 03, 2019 at 04:37:28PM -0400, Jagannathan Raman wrote: > qemu_thread_cancel() added to destroy a given running thread. > This will be needed in the following patches.
I don't see anything in the following patches that actually uses this new function. That is good though, because it is incredibly difficult to correctly use pthread_cancel() in such a way that you correctly release all memory and other resources (file descriptors) owned by the thread being cancelled. So this looks like it can thankfully be dropped. > > Signed-off-by: John G Johnson <john.g.john...@oracle.com> > Signed-off-by: Jagannathan Raman <jag.ra...@oracle.com> > Signed-off-by: Elena Ufimtseva <elena.ufimts...@oracle.com> > --- > include/qemu/thread.h | 1 + > util/qemu-thread-posix.c | 10 ++++++++++ > 2 files changed, 11 insertions(+) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
