Philippe Mathieu-Daudé <phi...@redhat.com> writes:
> On 8/22/19 3:47 PM, Marc-André Lureau wrote: >> Add a --engine option to select either docker, podman or auto. >> >> Among other advantages, podman allows to run rootless & daemonless >> containers, fortunately sharing compatible CLI with docker. >> >> With current podman, we have to use a uidmap trick in order to be able >> to rw-share the ccache directory with the container user. >> >> With a user 1000, the default mapping is: >> >> 1000 (host) -> 0 >> (container). >> So write access to /var/tmp/ccache ends will end with permission >> denied error. >> >> With "--uidmap 1000:0:1 --uidmap 0:1:1000", the mapping is: >> 1000 (host) -> 0 (container, 1st namespace) -> 1000 (container, 2nd >> namespace). >> (the rest is mumbo jumbo to avoid holes in the range of UIDs) >> >> A future podman version may have an option such as --userns-keep-uid. >> Thanks to Debarshi Ray <ri...@redhat.com> for the help! >> >> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> >> Acked-by: Alex Bennée <alex.ben...@linaro.org> >> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> >> --- >> tests/docker/docker.py | 48 +++++++++++++++++++++++++++++++++++++----- >> 1 file changed, 43 insertions(+), 5 deletions(-) >> >> diff --git a/tests/docker/docker.py b/tests/docker/docker.py >> index f15545aeea..ac5baab4ca 100755 >> --- a/tests/docker/docker.py >> +++ b/tests/docker/docker.py >> @@ -20,6 +20,7 @@ import hashlib >> import atexit >> import uuid >> import argparse >> +import enum > > This broke Shippable: > https://app.shippable.com/github/qemu/qemu/runs/1897/summary/console The patch to fix it is in my PR although there are more fixes for the fall-out coming in a new series. -- Alex Bennée
