Re: [Qemu-devel] [PATCH v1 2/2] tcg: Factor out probe_write() logic into probe_access()

[David Hildenbrand]

On 28.08.19 16:52, Richard Henderson wrote:
> On 8/28/19 4:10 AM, David Hildenbrand wrote:
>> +void *probe_access(CPUArchState *env, target_ulong addr, int size,
>> +                   MMUAccessType access_type, int mmu_idx, uintptr_t 
>> retaddr)
>>  {
>>      CPUState *cpu = env_cpu(env);
>>      CPUClass *cc;
>> +    int flags;
>>  
>>      g_assert(-(addr | TARGET_PAGE_MASK) >= size);
>> +    g_assert(mmu_idx == MMU_USER_IDX);
> 
> We ignore mmu_idx pretty much everywhere else.
> Why bother now?

Also true, I can drop this and simply use MMU_USER_IDX below.

-- 

Thanks,

David / dhildenb