Le 19/07/2019 à 15:14, Philippe Mathieu-Daudé a écrit : > GCC9 is confused by this comment when building with CFLAG > -Wimplicit-fallthrough=2: > > hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’: > hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through > [-Werror=implicit-fallthrough=] > 178 | ch |= 0x10; > | ~~~^~~~~~~ > hw/ipmi/ipmi_bmc_extern.c:181:5: note: here > 181 | default: > | ^~~~~~~ > cc1: all warnings being treated as errors > make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1 > > Rewrite the comment using 'fall through' which is recognized by > GCC and static analyzers. > > Reported-by: Stefan Weil <s...@weilnetz.de> > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > hw/ipmi/ipmi_bmc_extern.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c > index c0a8dac346..d4cbd210c4 100644 > --- a/hw/ipmi/ipmi_bmc_extern.c > +++ b/hw/ipmi/ipmi_bmc_extern.c > @@ -176,8 +176,7 @@ static void addchar(IPMIBmcExtern *ibe, unsigned char ch) > ibe->outbuf[ibe->outlen] = VM_ESCAPE_CHAR; > ibe->outlen++; > ch |= 0x10; > - /* No break */ > - > + /* fall through */ > default: > ibe->outbuf[ibe->outlen] = ch; > ibe->outlen++; >
Applied to my trivial-patches branch. Thanks, Laurent
