On 19/08/19 20:28, Paolo Bonzini wrote: > On 16/08/19 12:12, Thomas Huth wrote: >> This patch is *huge*, more than 800kB. It keeps being stuck in the the >> filter of the qemu-s390x list each time you send it. Please: >> >> 1) Try to break it up in more digestible pieces, e.g. change only one >> subsystem at a time (this is also better reviewable by people who are >> interested in one area) > > This is not really possible, since the patch is basically a > search-and-replace. You could perhaps use some magic > ("DEVICE_MEMOP_ENDIAN" or something like that) to allow a split, but it > would introduce more complication than anything else.
I'm stupid, at this point of the series it _would_ be possible to split the patch by subsystem. Still not sure it would be actually an advantage. Paolo > Agreed on the HTML though. :) > > Paolo >