Patchew URL:
https://patchew.org/QEMU/20190817073628.94473-1-ys...@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v23 00/22] Add RX archtecture support
Message-id: 20190817073628.94473-1-ys...@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
167ad36510 target/rx: remove unused functions.
2b54d74f6c BootLinuxConsoleTest: Test the RX-Virt machine
a7a74f8c79 Add rx-softmmu
4e35d7354f hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
629ed450b6 hw/rx: Honor -accel qtest
ccc16c3d03 hw/rx: RX Target hardware definition
aeb8e98e61 hw/char: RX62N serial communication interface (SCI)
b3c958c6f9 hw/timer: RX62N internal timer modules
db735f8758 hw/intc: RX62N interrupt controller (ICUa)
6b2f7573bd target/rx: Dump bytes for each insn during disassembly
58e24c963b target/rx: Collect all bytes during disassembly
9aca6d801d target/rx: Emit all disassembly in one prt()
ba40f7d032 target/rx: Use prt_ldmi for XCHG_mr disassembly
f97ff3e9e6 target/rx: Replace operand with prt_ldmi in disassembler
a17112201f target/rx: Disassemble rx_index_addr into a string
4be087aafe target/rx: RX disassembler
e4567d98d8 target/rx: CPU definition
82080d92fb target/rx: TCG helper
0dca0e544c target/rx: TCG translation
6a1541b3a3 hw/registerfields.h: Add 8bit and 16bit register macros
b62c1a4980 qemu/bitops.h: Add extract8 and extract16
b4f6acdb0a MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit b4f6acdb0afa (MAINTAINERS: Add RX)
2/22 Checking commit b62c1a49805c (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 6a1541b3a320 (hw/registerfields.h: Add 8bit and 16bit
register macros)
Use of uninitialized value within @rawlines in concatenation (.) or string at
./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 0dca0e544c06 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 82080d92fbe5 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit e4567d98d837 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 622 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 4be087aafe12 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit a17112201f57 (target/rx: Disassemble rx_index_addr into a
string)
9/22 Checking commit f97ff3e9e698 (target/rx: Replace operand with prt_ldmi in
disassembler)
10/22 Checking commit ba40f7d032c9 (target/rx: Use prt_ldmi for XCHG_mr
disassembly)
11/22 Checking commit 9aca6d801da4 (target/rx: Emit all disassembly in one
prt())
12/22 Checking commit 58e24c963bbe (target/rx: Collect all bytes during
disassembly)
13/22 Checking commit 6b2f7573bd61 (target/rx: Dump bytes for each insn during
disassembly)
14/22 Checking commit db735f875803 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit b3c958c6f946 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit aeb8e98e617b (hw/char: RX62N serial communication
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 401 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit ccc16c3d0358 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 480 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 629ed450b69f (hw/rx: Honor -accel qtest)
19/22 Checking commit 4e35d7354f10 (hw/rx: Restrict the RX62N microcontroller
to the RX62N CPU core)
20/22 Checking commit a7a74f8c79e8 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61:
new file mode 100644
total: 0 errors, 1 warnings, 73 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 2b54d74f6c93 (BootLinuxConsoleTest: Test the RX-Virt
machine)
22/22 Checking commit 167ad36510f2 (target/rx: remove unused functions.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
deleted file mode 100644
total: 0 errors, 1 warnings, 5 lines checked
Patch 22/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190817073628.94473-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
