On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: > Eduardo Habkost <ehabk...@redhat.com> writes: > > > We have this issue reported when using libvirt to hotplug CPUs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > > > Basically, libvirt is not copying die-id from > > query-hotpluggable-cpus, but die-id is now mandatory. > > Uh-oh, "is now mandatory": making an optional property mandatory is an > incompatible change. When did we do that? Commit hash, please. > > [...] >
I don't even see it as being optional ever - the property wasn't even recognized before commit 176d2cda0de introduced it as mandatory. Regards, Erik