On 7/29/19 6:36 PM, John Snow wrote: > This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394. > > It's not correct to just ignore an error code in a callback; we need to > handle that error and possible report failure to the guest so that they > don't wait indefinitely for an operation that will now never finish. > > This ought to help cases reported by Nutanix where iSCSI returns a > legitimate -ECANCELED for certain operations which should be propagated > normally. > > Reported-by: Shaju Abraham <shaju.abra...@nutanix.com> > Signed-off-by: John Snow <js...@redhat.com> Nobody's yelling, so this is getting staged on my IDE branch, alongside Paolo's dma-helpers fix. Thanks, applied to my IDE tree: https://github.com/jnsnow/qemu/commits/ide https://github.com/jnsnow/qemu.git --js