On 8/12/19 7:23 AM, Markus Armbruster wrote: > In my "build everything" tree, changing sysemu/sysemu.h triggers a > recompile of some 1800 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h, down from 5400 due to the > previous commit). > > Several headers include sysemu/sysemu.h just to get typedef > VMChangeStateEntry. Move it from sysemu/sysemu.h to qemu/typedefs.h. > Spell its structure tag the same while there. Drop the now > superfluous includes of sysemu/sysemu.h from headers. > > Touching sysemu/sysemu.h now recompiles some 1100 objects. > qemu/uuid.h also drops from 1800 to 1100, and > qapi/qapi-types-run-state.h from 5000 to 4400.
Nice :) > > Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > hw/usb/hcd-ehci.h | 1 - > include/hw/ide/internal.h | 3 ++- > include/hw/ppc/spapr_xive.h | 1 - > include/hw/scsi/scsi.h | 1 - > include/hw/virtio/virtio.h | 1 - > include/qemu/typedefs.h | 1 + > include/sysemu/sysemu.h | 1 - > hw/block/vhost-user-blk.c | 1 + > hw/block/virtio-blk.c | 1 + > hw/display/virtio-gpu.c | 1 + > hw/misc/macio/macio.c | 1 + > hw/net/virtio-net.c | 1 + > hw/s390x/s390-ccw.c | 1 + > hw/s390x/s390-virtio-ccw.c | 1 + > hw/scsi/scsi-bus.c | 1 + > hw/scsi/vhost-scsi.c | 1 + > hw/scsi/vhost-user-scsi.c | 1 + > hw/usb/hcd-ehci.c | 1 + > hw/virtio/virtio-rng.c | 1 + > hw/virtio/virtio.c | 1 + > vl.c | 6 +++--- > 21 files changed, 19 insertions(+), 9 deletions(-)
