On 12.08.19 17:28, David Hildenbrand wrote: > On 12.08.19 17:18, Thomas Huth wrote: >> On 8/12/19 1:27 PM, David Hildenbrand wrote: >>> Let's select the ASC before calling the function. This is a prepararion >>> to remove the ASC magic depending on the access mode from mmu_translate. >>> >>> There is currently no way to distinguish if we have code or data access. >>> For now, we were using code access, because especially when debugging with >>> the gdbstub, we want to read and disassemble what we single-step. >> >> IMHO we should add a "instruction" bit to MemTxAttrs and then use the >> ...page_attrs_debug() interface instead. But ok, that's likely really >> something for a separate clean-up, so for the time being: >> > > That sounds like a good idea, and then switching over to > cc->get_phys_page_attrs()
But looking at get_phys_page_attrs_debug() again, "MemTxAttrs *attrs" is an output value not an input value. So there wouldn't be a way to specify "what you want" from the caller. At least unless I am missing something :) > > Thanks! > >> Reviewed-by: Thomas Huth <th...@redhat.com> >> > > -- Thanks, David / dhildenb
