On 8/7/19 11:16 AM, Peter Maydell wrote: > How about we add this to the commit message? > > This changes the behaviour for load_reg() and load_reg_var() > when called with reg==15 from a 32-bit Thumb instruction: > previously they would have returned the incorrect value > of pc_curr + 6, and now they will return the architecturally > correct value of PC, which is pc_curr + 4. This will not > affect well-behaved guest software, because all of the places > we call these functions from T32 code are instructions where > using r15 is UNPREDICTABLE. Using the architectural PC value > here is more consistent with the T16 and A32 behaviour.
Looks good to me. r~
