Re: [Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/

[John Snow]

On 8/7/19 8:29 AM, Philippe Mathieu-Daudé wrote:
> On 8/6/19 11:40 PM, John Snow wrote:
>> On 8/6/19 11:14 AM, Markus Armbruster wrote:
>>> According to hw/ide/internal's file comment, only files in hw/ide/ are
>>> supposed to include it.  Drag reality slightly closer to supposition.
>>>
>>
>> The downside of having your internal include ripped away and stuck in
>> the includes/ folder.
> 
> Not sure this is a 'downside', it looks more than proper design issue to
> me (often the case with very old subsystems).
> 

For context, the "internal" header here used to actually be internal. It
was moved wholesale to the "public" includes directory, which makes it
easier for people to start stealing things from inside of it, which
causes trouble.

--js