On Wed, May 11, 2011 at 8:58 AM, Shribman, Aidan <aidan.shrib...@sap.com> wrote: > From: Aidan Shribman <aidan.shrib...@sap.com> > > [PATCH] Add warmup phase for live migration of large memory apps > > By invoking "migrate -w <url>" we initiate a background live-migration > transferring of dirty pages continuously until invocation of "migrate_end" > which attempts to complete the live migration operation.
What is the purpose of this patch? How and when do I use it? Some nitpicks: > @@ -81,6 +83,11 @@ int do_migrate(Monitor *mon, const QDict *qdict, QObject > **ret_data) > int blk = qdict_get_try_bool(qdict, "blk", 0); > int inc = qdict_get_try_bool(qdict, "inc", 0); > const char *uri = qdict_get_str(qdict, "uri"); > + is_migrate_warmup = qdict_get_try_bool(qdict, "warmup", 0); > + > + if (is_migrate_warmup) { > + detach = 1; /* as we need migrate_end to complte */ s/complte/complete/ > + } Please follow the coding style and put the closing curly brace on the same column as the 'if' statement. > +int qemu_savevm_state_warmup(Monitor *mon, QEMUFile *f) { > + int ret = 1; 1 is overwritten immediately. Stefan