On Tue, Aug 06, 2019 at 07:48:43AM +0200, Markus Armbruster wrote: > Markus Armbruster <arm...@redhat.com> writes: > > > Paolo Bonzini <pbonz...@redhat.com> writes: > > > >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > >> --- > >> Makefile | 4 ---- > >> 1 file changed, 4 deletions(-) > >> > >> diff --git a/Makefile b/Makefile > >> index 73fbba0..7b0e2f4 100644 > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -429,10 +429,6 @@ dummy := $(call unnest-vars,, \ > >> io-obj-y \ > >> common-obj-y \ > >> common-obj-m \ > >> - ui-obj-y \ > >> - ui-obj-m \ > >> - audio-obj-y \ > >> - audio-obj-m \ > >> trace-obj-y) > >> > >> include $(SRC_PATH)/tests/Makefile.include > > > > Reviewed-by: Markus Armbruster <arm...@redhat.com> > > Hmm... the two go back to > > commit 08a05b379ac56430cbb748882ff1b48dc9fe8729 > Author: Gerd Hoffmann <kra...@redhat.com> > Date: Tue Mar 6 08:40:49 2018 +0100 > > build: enable audio modules > > Add audio/ to common-obj-m variable. > > Also run both audio and ui variables through unnest-vars. > This avoids sdl.mo (exists in both audio/ and ui/) name clashes. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > Message-id: 20180306074053.22856-4-kra...@redhat.com > > Gerd, anything funny going on here, or is Paolo's patch okay?
Well, the commit message pretty much says it. We have sdl.mo in both ui/ and audio/ (final module names are audio-sdl.so and ui-sdl.so). This certainly was needed back when I added it. Possibly it can be removed now, I don't follow build system changes that closely. But it should be build-tested both ui/sdl and audio/sdl enabled. cheers, Gerd
