On Thu, Aug 01, 2019 at 04:10:34PM +0800, Ivan Ren wrote: >>> s->iteration_start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); >>>+ /* >>>+ * Update s->iteration_initial_bytes to match >s->iteration_start_time. >>>+ */ >>>+ s->iteration_initial_bytes = migration_total_bytes(s); >> >>Is this one necessary? We have sent out nothing yet. > >Yes, currently nothing has been sent yet at this point. > >Is that better to always match the update of iteration_initial_bytes >and iteration_start_time in a explicit way to avoid some potential missing? >
You may get some point. Well after a close look, we may find other potential problem. 1. To be consistency, we need to update iteration_initial_pages too. So my opinion is to wrap the update of these three counters into a helper function. So each time all of them. 2. In function ram_get_total_transferred_pages, do we missed multifd_bytes? -- Wei Yang Help you, Help me
