Patchew URL: https://patchew.org/QEMU/20190731160719.11396-1-alex.ben...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v4 00/54] plugins for TCG Message-id: 20190731160719.11396-1-alex.ben...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190731075652.17053-1-th...@redhat.com -> patchew/20190731075652.17053-1-th...@redhat.com * [new tag] patchew/20190731160719.11396-1-alex.ben...@linaro.org -> patchew/20190731160719.11396-1-alex.ben...@linaro.org Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp' Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out 'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3' Cloning into 'roms/edk2'... Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54' Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3' Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl' Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'... Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'CryptoPkg/Library/OpensslLib/openssl'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687' Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered for path 'boringssl' Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5' Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) registered for path 'pyca-cryptography' Cloning into 'boringssl'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f' Cloning into 'krb5'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked out 'b9ad6c49505c96a088326b62a52568e3484f2168' Cloning into 'pyca-cryptography'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out '09403100de2f6f1cdd0d484dcb8e620f1c335c8f' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out 'c79e0ecb84f4f1ee3f73f521622e264edd1bf174' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/opensbi'... Submodule path 'roms/opensbi': checked out 'ce228ee0919deb9957192d723eecc8aaae2697c6' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out 'bf0e13698872450164fa7040da36a95d2d4b326f' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out 'a5cab58e9a3fb6e168aba919c5669bea406573b4' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '0f4fe84658165e96ce35870fd19fc634e182e77b' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out '261ca8e779e5138869a45f174caa49be6a274501' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd3689267f92c5956e09cc7d1baa4700141662bff' Cloning into 'roms/u-boot-sam460ex'... Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588' Cloning into 'slirp'... Submodule path 'slirp': checked out 'f0da6726207b740f6101028b2992f918477a4b08' Cloning into 'tests/fp/berkeley-softfloat-3'... Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'tests/fp/berkeley-testfloat-3'... Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' 4618434 include/exec/cpu-defs.h: fix typo d260302 include/exec: wrap cpu_ldst.h in CONFIG_TCG 4a08e81 accel/stubs: reduce headers from tcg-stub dc047a8 tests/plugin: add hotpages plugin to breakdown memory access patterns 0031177 tests/plugin: add instruction execution breakdown bd83073 plugin: add qemu_plugin_insn_disas helper 719f27a tests/plugin: add a hotblocks plugin 0c2193f tests/tcg: enable plugin testing 4fda032 tests/plugin: add sample plugins fd7f586 linux-user: support -plugin option b484c3f vl: support -plugin option 720fb2d plugin: add API symbols to qemu-plugins.symbols 75048c5 translator: inject instrumentation from plugins 90d92af target/openrisc: fetch code with translator_ld bf3c443 target/xtensa: fetch code with translator_ld 1b3b92b target/sparc: fetch code with translator_ld f41eb29 target/riscv: fetch code with translator_ld 35e338c target/alpha: fetch code with translator_ld 9014aab target/m68k: fetch code with translator_ld 604625d target/hppa: fetch code with translator_ld f86b279 target/i386: fetch code with translator_ld 5bfcc20 target/sh4: fetch code with translator_ld 65656f9 target/ppc: fetch code with translator_ld 1338aac target/arm: fetch code with translator_ld 6ad7980 translator: add translator_ld{ub, sw, uw, l, q} 123a7b0 plugin-gen: add plugin_insn_append 2fc0fb1 cpu: hook plugin vcpu events 2ad986c *-user: plugin syscalls 12cf148 *-user: notify plugin of exit 5ef3c3d translate-all: notify plugin code of tb_flush ceffbf5 plugins: implement helpers for resolving hwaddr bfd0bef tcg: let plugins instrument virtual memory accesses 8c70962 atomic_template: add inline trace/plugin helpers b6d0321 atomic_template: fix indentation in GEN_ATOMIC_HELPER 59e11a6 plugin-gen: add module for TCG-related code b7ff8fb tcg: add tcg_gen_st_ptr 57dce44 cputlb: introduce get_page_addr_code_hostp c21fd8d cputlb: document get_page_addr_code 0156ea7 queue: add QTAILQ_REMOVE_SEVERAL 98bb420 plugin: add implementation of the api 90dff04 plugin: add core code dfc8157 plugin: add user-facing API c508aec configure: add --enable-plugins (MOVE TO END) efd9ca8 docs/devel: add plugins.rst design document 7e445c2 translate-all: use cpu_in_exclusive_work_context() in tb_flush e3927dd cpu: introduce cpu_in_exclusive_context() 2c1c22b tcg/README: fix typo s/afterwise/afterwards/ 0082b05 trace: add mmu_index to mem_info 43a9cd6 trace: expand mem_info:size_shift to 4 bits 92f8098 includes: remove stale [smp|max]_cpus externs b12d00f target/arm: remove run time semihosting checks 3964cfe target/arm: handle A-profile A32 semihosting at translate time 354ccbf target/arm: handle A-profile T32 semihosting at translate time c736511 target/arm: handle M-profile semihosting at translate time === OUTPUT BEGIN === 1/54 Checking commit c736511afb73 (target/arm: handle M-profile semihosting at translate time) 2/54 Checking commit 354ccbf7836a (target/arm: handle A-profile T32 semihosting at translate time) 3/54 Checking commit 3964cfed151e (target/arm: handle A-profile A32 semihosting at translate time) 4/54 Checking commit b12d00f866ff (target/arm: remove run time semihosting checks) 5/54 Checking commit 92f80985c6b7 (includes: remove stale [smp|max]_cpus externs) 6/54 Checking commit 43a9cd64afe9 (trace: expand mem_info:size_shift to 4 bits) 7/54 Checking commit 0082b05e9d82 (trace: add mmu_index to mem_info) ERROR: line over 90 characters #24: FILE: accel/tcg/atomic_template.h:63: + uint16_t info = glue(trace_mem_build_info_no_se, MEND)(SHIFT, false, ATOMIC_MMU_IDX); \ ERROR: line over 90 characters #33: FILE: accel/tcg/atomic_template.h:71: + uint16_t info = glue(trace_mem_build_info_no_se, MEND)(SHIFT, false, ATOMIC_MMU_IDX); \ ERROR: line over 90 characters #40: FILE: accel/tcg/atomic_template.h:77: + uint16_t info = glue(trace_mem_build_info_no_se, MEND)(SHIFT, true, ATOMIC_MMU_IDX); \ WARNING: line over 80 characters #321: FILE: trace/mem.h:21: +static uint16_t trace_mem_get_info(TCGMemOp op, unsigned int mmu_idx, bool store); total: 3 errors, 1 warnings, 261 lines checked Patch 7/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/54 Checking commit 2c1c22bc16e9 (tcg/README: fix typo s/afterwise/afterwards/) 9/54 Checking commit e3927dda7720 (cpu: introduce cpu_in_exclusive_context()) 10/54 Checking commit 7e445c2738b4 (translate-all: use cpu_in_exclusive_work_context() in tb_flush) 11/54 Checking commit efd9ca87d2ad (docs/devel: add plugins.rst design document) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 total: 0 errors, 1 warnings, 111 lines checked Patch 11/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/54 Checking commit c508aec11118 (configure: add --enable-plugins (MOVE TO END)) 13/54 Checking commit dfc81576c19a (plugin: add user-facing API) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 WARNING: architecture specific defines should be avoided #41: FILE: include/qemu/qemu-plugin.h:22: +#if defined _WIN32 || defined __CYGWIN__ WARNING: architecture specific defines should be avoided #49: FILE: include/qemu/qemu-plugin.h:30: + #if __GNUC__ >= 4 total: 0 errors, 3 warnings, 351 lines checked Patch 13/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/54 Checking commit 90dff041feaf (plugin: add core code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 ERROR: "foo * bar" should be "foo *bar" #190: FILE: include/qemu/plugin.h:132: +static inline struct qemu_plugin_insn * qemu_plugin_insn_alloc(void) ERROR: named QLIST_HEAD should be typedefed separately #399: FILE: plugins/core.c:37: +QLIST_HEAD(qemu_plugin_cb_head, qemu_plugin_cb); WARNING: line over 80 characters #618: FILE: plugins/core.c:256: + cbs = g_array_sized_new(false, false, sizeof(struct qemu_plugin_dyn_cb), 1); WARNING: Block comments use a leading /* on a separate line #909: FILE: plugins/loader.c:42: + { /* end of list */ } ERROR: externs should be avoided in .c files #915: FILE: plugins/loader.c:48: +extern struct qemu_plugin_state plugin; total: 3 errors, 3 warnings, 1261 lines checked Patch 14/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/54 Checking commit 98bb4205f8d1 (plugin: add implementation of the api) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 ERROR: if this code is redundant consider removing it #282: FILE: plugins/api.c:256: +#if 0 /* XXX FIXME should be SOFTMMU */ ERROR: "foo * bar" should be "foo *bar" #303: FILE: plugins/api.c:277: +static MachineState * get_ms(void) total: 2 errors, 1 warnings, 303 lines checked Patch 15/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/54 Checking commit 0156ea779e67 (queue: add QTAILQ_REMOVE_SEVERAL) WARNING: Block comments use a leading /* on a separate line #31: FILE: include/qemu/queue.h:433: + } while (/*CONSTCOND*/0) total: 0 errors, 1 warnings, 16 lines checked Patch 16/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/54 Checking commit c21fd8dfb8e0 (cputlb: document get_page_addr_code) 18/54 Checking commit 57dce445a292 (cputlb: introduce get_page_addr_code_hostp) 19/54 Checking commit b7ff8fb737a6 (tcg: add tcg_gen_st_ptr) 20/54 Checking commit 59e11a6c6781 (plugin-gen: add module for TCG-related code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 ERROR: if this code is redundant consider removing it #420: FILE: accel/tcg/plugin-gen.c:368: +#if 0 /* XXX: no longer needed? */ total: 1 errors, 1 warnings, 1168 lines checked Patch 20/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/54 Checking commit b6d032138a56 (atomic_template: fix indentation in GEN_ATOMIC_HELPER) 22/54 Checking commit 8c70962547d5 (atomic_template: add inline trace/plugin helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 296 lines checked Patch 22/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/54 Checking commit bfd0bef6abd9 (tcg: let plugins instrument virtual memory accesses) WARNING: line over 80 characters #171: FILE: include/exec/cpu_ldst_template.h:91: + uint16_t meminfo = trace_mem_build_info(SHIFT, false, MO_TE, false, mmu_idx); total: 0 errors, 1 warnings, 372 lines checked Patch 23/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/54 Checking commit ceffbf57661b (plugins: implement helpers for resolving hwaddr) 25/54 Checking commit 5ef3c3d45dd0 (translate-all: notify plugin code of tb_flush) 26/54 Checking commit 12cf1480ae24 (*-user: notify plugin of exit) 27/54 Checking commit 2ad986cc69bd (*-user: plugin syscalls) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93: new file mode 100644 total: 0 errors, 1 warnings, 127 lines checked Patch 27/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/54 Checking commit 2fc0fb11c7c5 (cpu: hook plugin vcpu events) 29/54 Checking commit 123a7b0c3078 (plugin-gen: add plugin_insn_append) 30/54 Checking commit 6ad7980f6247 (translator: add translator_ld{ub, sw, uw, l, q}) ERROR: Macros with multiple statements should be enclosed in a do - while loop #76: FILE: include/exec/translator.h:161: +#define DO_LOAD(type, name, shift) \ + set_helper_retaddr(1); \ + ret = name ## _p(g2h(pc)); \ + clear_helper_retaddr(); WARNING: Block comments use a leading /* on a separate line #109: FILE: include/exec/translator.h:194: +GEN_TRANSLATOR_LD(translator_ldub, ldb, uint8_t, 1, /* no swap needed */) total: 1 errors, 1 warnings, 116 lines checked Patch 30/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/54 Checking commit 1338aac82722 (target/arm: fetch code with translator_ld) 32/54 Checking commit 65656f9c3eea (target/ppc: fetch code with translator_ld) 33/54 Checking commit 5bfcc20d11c6 (target/sh4: fetch code with translator_ld) 34/54 Checking commit f86b27916216 (target/i386: fetch code with translator_ld) 35/54 Checking commit 604625d4780e (target/hppa: fetch code with translator_ld) 36/54 Checking commit 9014aab24680 (target/m68k: fetch code with translator_ld) 37/54 Checking commit 35e338c60b8f (target/alpha: fetch code with translator_ld) 38/54 Checking commit f41eb298b626 (target/riscv: fetch code with translator_ld) 39/54 Checking commit 1b3b92b10053 (target/sparc: fetch code with translator_ld) 40/54 Checking commit bf3c443ec239 (target/xtensa: fetch code with translator_ld) 41/54 Checking commit 90d92af84114 (target/openrisc: fetch code with translator_ld) 42/54 Checking commit 75048c56cd83 (translator: inject instrumentation from plugins) 43/54 Checking commit 720fb2d03f34 (plugin: add API symbols to qemu-plugins.symbols) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #120: new file mode 100644 total: 0 errors, 1 warnings, 151 lines checked Patch 43/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 44/54 Checking commit b484c3fd133c (vl: support -plugin option) 45/54 Checking commit fd7f58630fad (linux-user: support -plugin option) 46/54 Checking commit 4fda03223154 (tests/plugin: add sample plugins) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 296 lines checked Patch 46/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 47/54 Checking commit 0c2193fd7aa2 (tests/tcg: enable plugin testing) 48/54 Checking commit 719f27a8e85d (tests/plugin: add a hotblocks plugin) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 153 lines checked Patch 48/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 49/54 Checking commit bd8307360460 (plugin: add qemu_plugin_insn_disas helper) ERROR: "foo * bar" should be "foo *bar" #74: FILE: disas.c:530: +char * plugin_disas(CPUState *cpu, uint64_t addr, size_t size) ERROR: "foo * bar" should be "foo *bar" #136: FILE: include/disas/disas.h:16: +char * plugin_disas(CPUState *cpu, uint64_t addr, size_t size); ERROR: "foo * bar" should be "foo *bar" #155: FILE: include/qemu/qemu-plugin.h:334: +char * qemu_plugin_insn_disas(const struct qemu_plugin_insn *insn); total: 3 errors, 0 warnings, 158 lines checked Patch 49/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 50/54 Checking commit 0031177b24bf (tests/plugin: add instruction execution breakdown) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 ERROR: space required after that ',' (ctx:VxV) #99: FILE: tests/plugin/howvec.c:69: + { " Add/Sub (imm,tags)","asit", 0x1f800000, 0x11800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #122: FILE: tests/plugin/howvec.c:92: + { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #122: FILE: tests/plugin/howvec.c:92: + { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #124: FILE: tests/plugin/howvec.c:94: + { " AdvSimd ldst++", "advlssp",0xbf800000, 0x0d800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #128: FILE: tests/plugin/howvec.c:98: + { " ldst noalloc pair", "ldstnap",0x3b800000, 0x28000000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #132: FILE: tests/plugin/howvec.c:102: + { " ldst reg (reg off)","ldstro", 0x3b200b00, 0x38200800, COUNT_CLASS}, ^ WARNING: line over 80 characters #167: FILE: tests/plugin/howvec.c:137: + g_string_append_printf(report, "Class: %-24s\tcounted individually\n", ERROR: space required after that ',' (ctx:VxV) #183: FILE: tests/plugin/howvec.c:153: + g_string_append_printf(report,"Individual Instructions:\n"); ^ WARNING: line over 80 characters #189: FILE: tests/plugin/howvec.c:159: + g_string_append_printf(report, "Instr: %-24s\t(%ld hits)\t(op=%#08x/%s)\n", ERROR: "foo * bar" should be "foo *bar" #214: FILE: tests/plugin/howvec.c:184: +static uint64_t * find_counter(struct qemu_plugin_insn *insn) WARNING: line over 80 characters #246: FILE: tests/plugin/howvec.c:216: + GUINT_TO_POINTER(opcode)); total: 8 errors, 4 warnings, 308 lines checked Patch 50/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 51/54 Checking commit dc047a82f004 (tests/plugin: add hotpages plugin to breakdown memory access patterns) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 186 lines checked Patch 51/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 52/54 Checking commit 4a08e81629be (accel/stubs: reduce headers from tcg-stub) 53/54 Checking commit d260302d62f5 (include/exec: wrap cpu_ldst.h in CONFIG_TCG) 54/54 Checking commit 4618434e2366 (include/exec/cpu-defs.h: fix typo) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190731160719.11396-1-alex.ben...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
