On 30.07.19 16:57, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
>  tests/qemu-iotests/118     | 6 +++++-
>  tests/qemu-iotests/118.out | 4 ++--
>  2 files changed, 7 insertions(+), 3 deletions(-)

Personally, I wouldn’t mind a

    self.assert_qmp(result, 'return[0]/inserted/ro', read_only_node)

at the end of test_cycle(), but oh well:

Reviewed-by: Max Reitz <mre...@redhat.com>

(We’d also want it in other places, e.g. test_tray_open_change() should
check that it’s always False for floppy disks, and True for CDs.)

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to