* Cornelia Huck (coh...@redhat.com) wrote: > On Mon, 29 Jul 2019 17:29:01 +0100 > "Dr. David Alan Gilbert (git)" <dgilb...@redhat.com> wrote: > > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > > > Revert a couple of patches that break PCIe capabilities in virtio > > devices. The 'optional' revert is just reverted to make the main > > reversion trivial. > > Don't want to spoil the party here; but wasn't the optional stuff > removed because it was deemed to be a bad idea?
I'm perfectly happy to go either way with this; it maybe a bad idea but it's harmless I think. Dave > > > > Symptom: > > Loss of PCIe capabilities in virtio devices hung off PCIe bridges > > > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > > > > > Dr. David Alan Gilbert (2): > > Revert "Revert "globals: Allow global properties to be optional"" > > Revert "hw: report invalid disable-legacy|modern usage for > > virtio-1-only devs" > > > > hw/core/machine.c | 23 +++-------------------- > > hw/display/virtio-gpu-pci.c | 4 +--- > > hw/display/virtio-vga.c | 4 +--- > > hw/virtio/virtio-crypto-pci.c | 4 +--- > > hw/virtio/virtio-input-pci.c | 4 +--- > > hw/virtio/virtio-pci.c | 26 ++++++++++---------------- > > hw/virtio/virtio-pci.h | 31 ++++++------------------------- > > include/hw/qdev-core.h | 3 +++ > > qom/object.c | 3 +++ > > 9 files changed, 29 insertions(+), 73 deletions(-) > > > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
