Re: [Qemu-devel] [PATCH] usb-linux: Add missing break statement

[Hans de Goede]

Thanks, good catch.

Acked-by: Hans de Goede <hdego...@redhat.com>

On 05/07/2011 10:10 PM, Stefan Weil wrote:

cppcheck report:
usb-linux.c:661: warning: Redundant assignment of "len" in switch

Please check whether adding a break statement
is the correct solution for this warning.

Cc: Hans de Goede<hdego...@redhat.com>
Cc: Gerd Hoffmann<kra...@redhat.com>
Signed-off-by: Stefan Weil<w...@mail.berlios.de>
---
  usb-linux.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index 36a01ea..0ef1d26 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -659,6 +659,7 @@ static int usb_host_handle_iso_data(USBHostDevice *s, 
USBPacket *p, int in)
                          switch(errno) {
                          case ETIMEDOUT:
                              len = USB_RET_NAK;
+                            break;
                          case EPIPE:
                          default:
                              len = USB_RET_STALL;