On 7/25/19 1:38 PM, Philippe Mathieu-Daudé wrote:
> On 7/25/19 11:55 AM, tony.ngu...@bt.com wrote:
>> Signed-off-by: Tony Nguyen <tony.ngu...@bt.com>
>> ---
>> accel/tcg/cputlb.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
>> index 523be4c..a4a0bf7 100644
>> --- a/accel/tcg/cputlb.c
>> +++ b/accel/tcg/cputlb.c
>> @@ -906,8 +906,8 @@ static uint64_t io_readx(CPUArchState *env,
>> CPUIOTLBEntry *iotlbentry,
>> qemu_mutex_lock_iothread();
>> locked = true;
>> }
>> - r = memory_region_dispatch_read(mr, mr_offset,
>> - &val, size, iotlbentry->attrs);
>> + r = memory_region_dispatch_read(mr, mr_offset, &val, SIZE_MEMOP(size),
>> + iotlbentry->attrs);
>> if (r != MEMTX_OK) {
>> hwaddr physaddr = mr_offset +
>> section->offset_within_address_space -
>> @@ -947,8 +947,8 @@ static void io_writex(CPUArchState *env, CPUIOTLBEntry
>> *iotlbentry,
>> qemu_mutex_lock_iothread();
>> locked = true;
>> }
>> - r = memory_region_dispatch_write(mr, mr_offset,
>> - val, size, iotlbentry->attrs);
>> + r = memory_region_dispatch_write(mr, mr_offset, val, SIZE_MEMOP(size),
>> + iotlbentry->attrs);
>> if (r != MEMTX_OK) {
>> hwaddr physaddr = mr_offset +
>> section->offset_within_address_space -
>> --
>> 1.8.3.1
>>
>
> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Hmm now reading patch #11 I think you should also convert
cpu_transaction_failed() in this patch, not in #11, and this will make
#11 easier to review.
