On 24/07/19 14:35, Stefano Garzarella wrote: >> Isn't the success case missing a g_mapped_file_unref? It has to be done >> unconditionally since now rom_add_elf_program adds a separate reference. > Sure, I had this in mind, since I initialized mapped_file to NULL, but > I didn't see the return before "fail:" label! > Maybe I'll change the end of load_elf() in this way: > > - g_free(phdr); > if (lowaddr) > *lowaddr = (uint64_t)(elf_sword)low; > if (highaddr) > *highaddr = (uint64_t)(elf_sword)high; > - return total_size; > + ret = total_size; > fail: > - g_free(data); > + g_mapped_file_unref(mapped_file); > g_free(phdr); > return ret; > } > >
Yes, this looks better! Paolo
