On 05/06/2011 04:23 PM, Serge E. Hallyn wrote:
Quoting Stefan Berger (stef...@linux.vnet.ibm.com):
This patch adds support for TPM command line options.
The command line supported here (considering the libtpms based
backend) are
./qemu-... -tpm type=<type>,path=<path to blockstorage file>,
and
./qemu-... -tpm ?
where the latter works similar to -soundhw ? and shows a list of
available TPM backends (i.e., libtpms-based, Xen).
Only the 'type' is interpreted in arch_init.c. Using this parameter,
the backend is chosen, i.e., 'builtin' for the libtpms-based
builtin TPM. The interpretation of the other parameters along with
determining whether enough parameters were provided is pushed into
the backend driver, which needs to implement the interface function
'handle_options' and return true if the VM can be started or 'false'
if not enough or bad parameters were provided.
v4:
- coding style fixes
v3:
- added hw/tpm_tis.h to this patch so Qemu compiles at this stage
Signed-off-by: Stefan Berger<stef...@linux.vnet.ibm.com>
Thanks, Stefan. Two nits:
+static QemuOptsList qemu_tpm_opts = {
+ .name = "tpm",
+ .head = QTAILQ_HEAD_INITIALIZER(qemu_tpm_opts.head),
+ .desc = {
+ {
+ .name = "type",
+ .type = QEMU_OPT_STRING,
+ .help = "Type of TPM backend",
+ },
+ {
+ .name = "path",
+ .type = QEMU_OPT_STRING,
+ .help = "Persitent storage for TPM state",
Persistent.
Oh, typo. Will fix it.
...
+# else /* CONFIG_TPM */
+
+void select_tpm(const char *optarg)
+{
+ (void)optarg;
+}
I realize this should never get called if !CONFIG_TPM, but that still
doesn't seem like cause to go directly calling a potentially NULL
string.
(void)optarg is just there to make the compiler not put out a warning
about an unused parameter. I could have used __attribute__((unused))
instead but chose this one here. It's not calling anything.
Thanks!
Stefan
Otherwise, fwiw
Acked-by: Serge Hallyn<serge.hal...@ubuntu.com>
thanks,
-serge
