On Thu, May 05, 2011 at 05:40:19PM +0200, Jes Sorensen wrote: > On 05/05/11 17:38, Michael S. Tsirkin wrote: > > On Thu, May 05, 2011 at 05:36:04PM +0200, Jes Sorensen wrote: > >> > On 05/05/11 17:18, Michael S. Tsirkin wrote: > >>>>> > >> > A memory size can obviously not be bigger than the maximum > >>>>> > >> > physical > >>>>> > >> > address, so I find it really hard to see how this could overflow. > >>> > > For example, a 4G size does not fit in 32 bits. > >> > > >> > That is the only corner case > > True. > > > >> > you can handle that by -1 if you like. > > But then all users need to be updated. > > Seems easier to break out of the loop easier. > > It's likely not a real problem, certainly not on a pc, > > don't know about other systems. > > I think it is quite fair to limit the amount of memory we support when > running 32 bit qemu binaries. I would expect more things to break than > just this if we tried to support 4GB of RAM on a 32 bit host. > > Cheers, > Jes
Fair enough.
