On Thu, 11 Jul 2019 at 14:08, Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > Previous to commit ddb6f2254, the DQ2 bit was incorrectly set > during PROGRAM command (0xA0). The commit reordered the switch > cases to only set the DQ2 bit for the ERASE commands using a > fallthrough, but did not explicit the fallthrough is intentional. > > Mark the switch fallthrough with a comment interpretable by C > preprocessors and static analysis tools. > > Reported-by: Coverity (CID 1403012) > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > hw/block/pflash_cfi02.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c > index 83084b9d72..f68837a449 100644 > --- a/hw/block/pflash_cfi02.c > +++ b/hw/block/pflash_cfi02.c > @@ -367,6 +367,7 @@ static uint64_t pflash_read(void *opaque, hwaddr offset, > unsigned int width) > case 0x30: /* Sector Erase */ > /* Toggle bit 2 during erase, but not program. */ > toggle_dq2(pfl); > + /* fall through */ > case 0xA0: /* Program */ > /* Toggle bit 6 */ > toggle_dq6(pfl); > --
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
