Patchew URL: https://patchew.org/QEMU/20190703210821.27550-1-ehabk...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL v5 00/43] Machine and x86 queue, 2019-07-03 Message-id: 20190703210821.27550-1-ehabk...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190703210821.27550-1-ehabk...@redhat.com -> patchew/20190703210821.27550-1-ehabk...@redhat.com Switched to a new branch 'test' e26968f tests: use -numa memdev option in tests instead of legacy 'mem' option 447d6d4 numa: allow memory-less nodes when using memdev as backend 764f45e numa: Make deprecation warnings conditional on !qtest_enabled() 372daf9 i386: Add Cascadelake-Server-v2 CPU model 1f7eb57 docs: Deprecate CPU model runnability guarantees 4a0035e i386: Make unversioned CPU models be aliases 20900a7 i386: Replace -noTSX, -IBRS, -IBPB CPU models with aliases 166fe70 i386: Define -IBRS, -noTSX, -IBRS versions of CPU models a89190a i386: Register versioned CPU models 56ffcb3 i386: Get model-id from CPU object on "-cpu help" 67e4979 i386: Add x-force-features option for testing 518bdad qmp: Add "alias-of" field to query-cpu-definitions cd002fc i386: Introduce SnowRidge CPU model e1310a8 qmp: Add deprecation information to query-machines 8d52c8a vl.c: Add -smp, dies=* command line support and update doc c99c25e machine: Refactor smp_parse() in vl.c as MachineClass::smp_parse() 92c1d48 target/i386: Add CPUID.1F generation support for multi-dies PCMachine 2916d9c i386: Remove unused host_cpudef variable 772d2d1 x86/cpu: use FeatureWordArray to define filtered_features 3fd83d5 i386: make 'hv-spinlocks' a regular uint32 property c890e36 i386: Fix signedness of hyperv_spinlock_attempts 2ee6343 i386: Don't print warning if phys-bits was set automatically a79d3b1 deprecate -mem-path fallback to anonymous RAM 7adb2d0 target/i386: fix feature check in hyperv-stub.c 0b56873 hppa: Delete unused hppa_cpu_list() function 5be5f4b numa: deprecate implict memory distribution between nodes 83e35ab numa: deprecate 'mem' parameter of '-numa node' option 974440f machine: show if CLI option '-numa node, mem' is supported in QAPI schema 5de1395 pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size() b40da5f i386: Update new x86_apicid parsing rules with die_offset support fbbe2b7 i386/cpu: Consolidate die-id validity in smp context f92d9f8 hw/i386: Adjust nr_dies with configured smp_dies for PCMachine 8373ee6 i386: Add die-level cpu topology to x86CPU on PCMachine 47e130a vl.c: Replace smp global variables with smp machine properties 78bcf8e hw: Replace global smp variables with MachineState for all remaining archs d547c96 hw/arm: Replace global smp variables with machine smp properties 1e9d486 hw/i386: Replace global smp variables with machine smp properties 4c58559 hw/s390x: Replace global smp variables with machine smp properties ba70985 hw/riscv: Replace global smp variables with machine smp properties 4a0ba9a hw/ppc: Replace global smp variables with machine smp properties 9ab64d0 general: Replace global smp variables with smp machine properties 266a798 machine: Refactor smp-related call chains to pass MachineState cb578f9 hw/boards: Add struct CpuTopology to MachineState === OUTPUT BEGIN === 1/43 Checking commit cb578f909d0c (hw/boards: Add struct CpuTopology to MachineState) 2/43 Checking commit 266a79866dda (machine: Refactor smp-related call chains to pass MachineState) 3/43 Checking commit 9ab64d0fb399 (general: Replace global smp variables with smp machine properties) 4/43 Checking commit 4a0ba9a730fd (hw/ppc: Replace global smp variables with machine smp properties) 5/43 Checking commit ba7098542206 (hw/riscv: Replace global smp variables with machine smp properties) 6/43 Checking commit 4c58559cf5fe (hw/s390x: Replace global smp variables with machine smp properties) 7/43 Checking commit 1e9d486608b0 (hw/i386: Replace global smp variables with machine smp properties) 8/43 Checking commit d547c9689615 (hw/arm: Replace global smp variables with machine smp properties) 9/43 Checking commit 78bcf8e082dc (hw: Replace global smp variables with MachineState for all remaining archs) 10/43 Checking commit 47e130a8a78f (vl.c: Replace smp global variables with smp machine properties) 11/43 Checking commit 8373ee61e3ec (i386: Add die-level cpu topology to x86CPU on PCMachine) 12/43 Checking commit f92d9f8b7ef9 (hw/i386: Adjust nr_dies with configured smp_dies for PCMachine) 13/43 Checking commit fbbe2b7e7095 (i386/cpu: Consolidate die-id validity in smp context) 14/43 Checking commit b40da5fdee3f (i386: Update new x86_apicid parsing rules with die_offset support) 15/43 Checking commit 5de139533a1b (pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()) 16/43 Checking commit 974440fdbd02 (machine: show if CLI option '-numa node, mem' is supported in QAPI schema) 17/43 Checking commit 83e35abe8ce4 (numa: deprecate 'mem' parameter of '-numa node' option) 18/43 Checking commit 5be5f4bf504c (numa: deprecate implict memory distribution between nodes) 19/43 Checking commit 0b5687394f83 (hppa: Delete unused hppa_cpu_list() function) 20/43 Checking commit 7adb2d0dacba (target/i386: fix feature check in hyperv-stub.c) 21/43 Checking commit a79d3b183e28 (deprecate -mem-path fallback to anonymous RAM) 22/43 Checking commit 2ee6343435c9 (i386: Don't print warning if phys-bits was set automatically) 23/43 Checking commit c890e364f986 (i386: Fix signedness of hyperv_spinlock_attempts) 24/43 Checking commit 3fd83d5832e9 (i386: make 'hv-spinlocks' a regular uint32 property) 25/43 Checking commit 772d2d161121 (x86/cpu: use FeatureWordArray to define filtered_features) 26/43 Checking commit 2916d9cbce4e (i386: Remove unused host_cpudef variable) 27/43 Checking commit 92c1d4878308 (target/i386: Add CPUID.1F generation support for multi-dies PCMachine) 28/43 Checking commit c99c25ebf4ec (machine: Refactor smp_parse() in vl.c as MachineClass::smp_parse()) 29/43 Checking commit 8d52c8a67bd1 (vl.c: Add -smp, dies=* command line support and update doc) 30/43 Checking commit e1310a8f1488 (qmp: Add deprecation information to query-machines) 31/43 Checking commit cd002fc2be3f (i386: Introduce SnowRidge CPU model) 32/43 Checking commit 518bdad584b6 (qmp: Add "alias-of" field to query-cpu-definitions) 33/43 Checking commit 67e4979d802c (i386: Add x-force-features option for testing) 34/43 Checking commit 56ffcb3eaf9d (i386: Get model-id from CPU object on "-cpu help") 35/43 Checking commit a89190addf18 (i386: Register versioned CPU models) WARNING: line over 80 characters #100: FILE: target/i386/cpu.c:1482: +static const X86CPUVersionDefinition *x86_cpu_def_get_versions(X86CPUDefinition *def) WARNING: Block comments use a leading /* on a separate line #105: FILE: target/i386/cpu.c:1487: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #122: FILE: target/i386/cpu.c:1883: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #134: FILE: target/i386/cpu.c:1942: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #146: FILE: target/i386/cpu.c:2011: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #158: FILE: target/i386/cpu.c:2086: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #170: FILE: target/i386/cpu.c:2127: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #182: FILE: target/i386/cpu.c:2170: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #194: FILE: target/i386/cpu.c:2251: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #206: FILE: target/i386/cpu.c:2294: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #218: FILE: target/i386/cpu.c:2339: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #230: FILE: target/i386/cpu.c:2422: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #242: FILE: target/i386/cpu.c:2519: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #254: FILE: target/i386/cpu.c:2626: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: Block comments use a leading /* on a separate line #266: FILE: target/i386/cpu.c:3139: + .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } }, WARNING: line over 80 characters #333: FILE: target/i386/cpu.c:4117: + for (vdef = x86_cpu_def_get_versions(model->cpudef); vdef->version; vdef++) { WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #509: new file mode 100644 ERROR: line over 90 characters #552: FILE: tests/acceptance/x86_cpu_model_versions.py:39: + '%s.alias-of (%s) is not a valid CPU model name' % (c['name'], c['alias-of'])) ERROR: line over 90 characters #555: FILE: tests/acceptance/x86_cpu_model_versions.py:42: + '%s.alias-of (%s) points to another alias' % (c['name'], c['alias-of'])) WARNING: line over 80 characters #591: FILE: tests/acceptance/x86_cpu_model_versions.py:78: + """Check if pc-*-4.0 unversioned CPU model won't be reported as aliases""" WARNING: line over 80 characters #598: FILE: tests/acceptance/x86_cpu_model_versions.py:85: + cpus = dict((m['name'], m) for m in self.vm.command('query-cpu-definitions')) WARNING: line over 80 characters #601: FILE: tests/acceptance/x86_cpu_model_versions.py:88: + 'unversioned Cascadelake-Server CPU model must not be static') total: 2 errors, 20 warnings, 550 lines checked Patch 35/43 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 36/43 Checking commit 166fe709d0d7 (i386: Define -IBRS, -noTSX, -IBRS versions of CPU models) WARNING: Block comments use a leading /* on a separate line #36: FILE: target/i386/cpu.c:1863: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #39: FILE: target/i386/cpu.c:1866: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #57: FILE: target/i386/cpu.c:1933: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #60: FILE: target/i386/cpu.c:1936: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #78: FILE: target/i386/cpu.c:2011: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #81: FILE: target/i386/cpu.c:2014: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #99: FILE: target/i386/cpu.c:2097: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #102: FILE: target/i386/cpu.c:2100: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #121: FILE: target/i386/cpu.c:2274: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #139: FILE: target/i386/cpu.c:2292: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #152: FILE: target/i386/cpu.c:2305: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #155: FILE: target/i386/cpu.c:2308: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #173: FILE: target/i386/cpu.c:2489: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #186: FILE: target/i386/cpu.c:2502: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #198: FILE: target/i386/cpu.c:2514: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #201: FILE: target/i386/cpu.c:2517: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #219: FILE: target/i386/cpu.c:2618: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #222: FILE: target/i386/cpu.c:2621: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #243: FILE: target/i386/cpu.c:2737: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #246: FILE: target/i386/cpu.c:2740: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #264: FILE: target/i386/cpu.c:3266: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #267: FILE: target/i386/cpu.c:3269: + { /* end of list */ } total: 0 errors, 22 warnings, 240 lines checked Patch 36/43 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 37/43 Checking commit 20900a70ab4d (i386: Replace -noTSX, -IBRS, -IBPB CPU models with aliases) 38/43 Checking commit 4a0035ee1441 (i386: Make unversioned CPU models be aliases) WARNING: line over 80 characters #267: FILE: tests/acceptance/x86_cpu_model_versions.py:108: + """Check if unversioned CPU model is an alias pointing to right version""" WARNING: line over 80 characters #272: FILE: tests/acceptance/x86_cpu_model_versions.py:113: + cpus = dict((m['name'], m) for m in self.vm.command('query-cpu-definitions')) WARNING: line over 80 characters #275: FILE: tests/acceptance/x86_cpu_model_versions.py:116: + 'unversioned Cascadelake-Server CPU model must not be static') ERROR: line over 90 characters #276: FILE: tests/acceptance/x86_cpu_model_versions.py:117: + self.assertEquals(cpus['Cascadelake-Server'].get('alias-of'), 'Cascadelake-Server-v1', WARNING: line over 80 characters #277: FILE: tests/acceptance/x86_cpu_model_versions.py:118: + 'Cascadelake-Server must be an alias of Cascadelake-Server-v1') WARNING: line over 80 characters #369: FILE: tests/acceptance/x86_cpu_model_versions.py:210: + """Check if unversioned CPU model is an alias pointing to some version""" WARNING: line over 80 characters #374: FILE: tests/acceptance/x86_cpu_model_versions.py:215: + cpus = dict((m['name'], m) for m in self.vm.command('query-cpu-definitions')) WARNING: line over 80 characters #377: FILE: tests/acceptance/x86_cpu_model_versions.py:218: + 'unversioned Cascadelake-Server CPU model must not be static') ERROR: line over 90 characters #378: FILE: tests/acceptance/x86_cpu_model_versions.py:219: + self.assertTrue(re.match('Cascadelake-Server-v[0-9]+', cpus['Cascadelake-Server']['alias-of']), WARNING: line over 80 characters #379: FILE: tests/acceptance/x86_cpu_model_versions.py:220: + 'Cascadelake-Server must be an alias of versioned CPU model') total: 2 errors, 8 warnings, 319 lines checked Patch 38/43 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 39/43 Checking commit 1f7eb57566a2 (docs: Deprecate CPU model runnability guarantees) 40/43 Checking commit 372daf905e41 (i386: Add Cascadelake-Server-v2 CPU model) WARNING: Block comments use a leading /* on a separate line #45: FILE: target/i386/cpu.c:2355: + { /* end of list */ } WARNING: Block comments use a leading /* on a separate line #48: FILE: target/i386/cpu.c:2358: + { /* end of list */ } ERROR: line over 90 characters #78: FILE: tests/acceptance/x86_cpu_model_versions.py:242: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #81: FILE: tests/acceptance/x86_cpu_model_versions.py:245: + 'pc-i440fx-4.1 + Cascadelake-Server should not have arch-capabilities') ERROR: line over 90 characters #86: FILE: tests/acceptance/x86_cpu_model_versions.py:250: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #89: FILE: tests/acceptance/x86_cpu_model_versions.py:253: + 'pc-i440fx-4.0 + Cascadelake-Server should not have arch-capabilities') ERROR: line over 90 characters #95: FILE: tests/acceptance/x86_cpu_model_versions.py:259: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities') ERROR: line over 90 characters #98: FILE: tests/acceptance/x86_cpu_model_versions.py:262: + 'pc-i440fx-4.0 + Cascadelake-Server,+arch-capabilities should have arch-capabilities') ERROR: line over 90 characters #103: FILE: tests/acceptance/x86_cpu_model_versions.py:267: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,-arch-capabilities') ERROR: line over 90 characters #106: FILE: tests/acceptance/x86_cpu_model_versions.py:270: + 'pc-i440fx-4.1 + Cascadelake-Server,-arch-capabilities should not have arch-capabilities') ERROR: line over 90 characters #112: FILE: tests/acceptance/x86_cpu_model_versions.py:276: + vm.add_args('-cpu', 'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #115: FILE: tests/acceptance/x86_cpu_model_versions.py:279: + 'pc-i440fx-4.1 + Cascadelake-Server-v1 should not have arch-capabilities') ERROR: line over 90 characters #120: FILE: tests/acceptance/x86_cpu_model_versions.py:284: + vm.add_args('-cpu', 'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #123: FILE: tests/acceptance/x86_cpu_model_versions.py:287: + 'pc-i440fx-4.1 + Cascadelake-Server-v1 should have arch-capabilities') ERROR: line over 90 characters #129: FILE: tests/acceptance/x86_cpu_model_versions.py:293: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities') ERROR: line over 90 characters #132: FILE: tests/acceptance/x86_cpu_model_versions.py:296: + 'pc-i440fx-4.0 + Cascadelake-Server-v1,+arch-capabilities should have arch-capabilities') ERROR: line over 90 characters #137: FILE: tests/acceptance/x86_cpu_model_versions.py:301: + vm.add_args('-cpu', 'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off,-arch-capabilities') ERROR: line over 90 characters #140: FILE: tests/acceptance/x86_cpu_model_versions.py:304: + 'pc-i440fx-4.1 + Cascadelake-Server-v2,-arch-capabilities should not have arch-capabilities') total: 16 errors, 2 warnings, 102 lines checked Patch 40/43 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 41/43 Checking commit 764f45e604df (numa: Make deprecation warnings conditional on !qtest_enabled()) WARNING: line over 80 characters #52: FILE: hw/core/numa.c:412: + warn_report("Default splitting of RAM between nodes is deprecated," total: 0 errors, 1 warnings, 33 lines checked Patch 41/43 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 42/43 Checking commit 447d6d477c04 (numa: allow memory-less nodes when using memdev as backend) 43/43 Checking commit e26968f29e46 (tests: use -numa memdev option in tests instead of legacy 'mem' option) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190703210821.27550-1-ehabk...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
