Le 03/07/2019 à 16:45, Peter Maydell a écrit :
> On Tue, 2 Jul 2019 at 13:39, Laurent Vivier <laur...@vivier.eu> wrote:
>>
>> The following changes since commit 7d0e02405fc02a181319b1ab8681d2f72246b7c6:
>>
>> Merge remote-tracking branch
>> 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2019-07-01
>> 17:40:32 +0100)
>>
>> are available in the Git repository at:
>>
>> git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>
>> for you to fetch changes up to 7c955080d40ccc7952a0479bc160f2b048c0af53:
>>
>> docs/devel/testing: Fix typo in dockerfile path (2019-07-02 10:12:32 +0200)
>>
>> ----------------------------------------------------------------
>> Fix typo, fix sys_cache_info() on FreeBSD/powerpc,
>> change virtio-rng default to urandom
>>
>> ----------------------------------------------------------------
>
> Hi; this makes 'make check' fail on OSX:
>
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> tests/test-char -m=quick -k --tap < /dev/null |
> ./scripts/tap-driver.pl --test-name="test-char"
> Assertion failed: ((isize & (isize - 1)) == 0), function
> init_cache_info, file
> /Users/pm215/src/qemu-for-merges/util/cacheinfo.c, line 179.
>
> I guess this is the sys_cache_info change.
OK, I will try to reproduce the problem.
I think before this patch (regarding the kind of change we have
introduced) isize and dsize were always set to 0 and then changed to 16
in fallback_cache_info()... or perhaps MacOS X sysctlbyname() needs a long.
Is there a HOWTO explaining how to build QEMU on MacOS X?
I'm going to resend the PR without this patch.
Thank you,
Laurent
