On Tue, Jul 02, 2019 at 07:27:13PM +0100, Peter Maydell wrote: > On Tue, 2 Jul 2019 at 19:22, Michael S. Tsirkin <m...@redhat.com> wrote: > > > > On Tue, Jul 02, 2019 at 06:20:01PM +0100, Peter Maydell wrote: > > > On Tue, 2 Jul 2019 at 18:01, Michael S. Tsirkin <m...@redhat.com> wrote: > > > > This isn't from mainline. We have a bit of a deadlock with linux merge > > > > window opening soon. I think it's reasonable temporarily > > > > and then before release either virtio-pmem gets there or I will > > > > revert it and drop the header. > > > > > > It's definitely not ideal: until the headers are actually > > > upstream there's no guarantee that they won't change ABI. > > > > But then I'm watching it, if I see that I'll drop the device from qemu for > > now. > > OK; I guess we can take this for now if we make sure we revert > if the headers aren't upstream by the time we get to say rc2 > (23rd July). (That is, we'd want to do any revert shortly after > rc2, since rc3 might be the last rc before release.)
Right, that's the plan. > > > Are the headers at least in some kvm-next or equivalent tree ? > > > > > > Yes - libnvdimm maintainer's tree. > > > > > When are they expected to hit mainline? > > > > Next merge window. > > When's that? Likely opens next Sunday and lasts 2 weeks. So we'll know by July 23. > thanks > -- PMM
