On 02.07.19 00:59, John Snow wrote: > > > On 6/27/19 6:32 PM, Max Reitz wrote: >> unittest-style tests generally do not use the log file, but VM.run_job() >> can still be useful to them. Add a parameter to it that hides its >> output from the log file. >> >> Signed-off-by: Max Reitz <mre...@redhat.com> > > Wondering out loud: > > can log() (and by extension qmp_log, and run_job) be made to use the > python logging module and we can configure the logging environment > instead of bespoke arguments to avoid ever engaging the log? > > We could theoretically just pre-disable iotests log output for unittest > style tests, unless you run in debug mode where we allow it. > > I don't have a specific proposal for how to accomplish this, I think > there are some nuances to Python logging that I don't quite understand. > Maybe Cleber Rosa can help advise? > > I'd like to toy with this idea; it seems like this won't be the last > time we want to turn output on/off.
Sounds good. But considering this is just test infrastructure, I’ll leave that for when someone(TM) gets around to doing it. (Hopefully when the next function is about to get a @use_log parameter.) Max
signature.asc
Description: OpenPGP digital signature
