On Mon, 1 Jul 2019 at 19:25, Corey Minyard <miny...@acm.org> wrote: > > On Mon, Jul 01, 2019 at 07:10:50PM +0100, Peter Maydell wrote: > > I have to say I'm not entirely happy with applying a pullreq > > with patches that are unreviewed and were last posted on list > > over six months ago. Can you post a v2 to try to solicit code > > review for them before we put them into master, please? > > > > (Sometimes patches don't get review, and we generally take > > them anyway; I do that myself from time to time. It's the > > combination of the six-months-since-patches-posted plus the > > imminent freeze deadline that gives me pause in this case.) > > Will do. > > I looked around and tried to find the freeze dates, and I couldn't > find anything published. If I had known it was close, I would have > waited.
Thanks. (Our schedule is on the wiki at https://wiki.qemu.org/Planning/4.1 -- but we don't publicise that url very much so it's easy to overlook it.) This is a pretty small change so if it gets review we can probably fit it in before rc0 or rc1. -- PMM