On Tue, 16 Apr 2019 at 02:39, Andrey Smirnov <andrew.smir...@gmail.com> wrote: > > Expression to calculate update_msi_mapping in code handling writes to > DESIGNWARE_PCIE_MSI_INTR0_ENABLE is missing an ! operator and should > be: > > !!root->msi.intr[0].enable ^ !!val; > > so that MSI mapping is updated when enabled transitions from either > "none" -> "any" or "any" -> "none". Since that register shouldn't be > written to very often, change the code to update MSI mapping > unconditionally instead of trying to fix the update_msi_mapping logic. > > Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com> > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: Michael S. Tsirkin <m...@redhat.com> > Cc: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.org > ---
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
