On Fri, Jun 28, 2019 at 05:18:46PM -0300, Eduardo Habkost wrote: > On Fri, Jun 28, 2019 at 11:02:17AM -0400, Wainer dos Santos Moschetta wrote: > > Until now the suite of acceptance tests doesn't exercise > > QEMU with kvm enabled. So this introduces a simple test > > that boots the Linux kernel and checks it boots on the > > accelerator correctly. > > > > Signed-off-by: Wainer dos Santos Moschetta <waine...@redhat.com> > > Why not just change the existing test_x86_64_pc() test case to > use KVM by default? We can use "accel=kvm:tcg" to allow it to > fall back to TCG if KVM is not available. > > -- > Eduardo
I though of something similar, but not exactly the same. An example can be seen here: https://travis-ci.org/clebergnu/qemu/jobs/551437429#L3350 IMO, it's a good practice to be able to briefly describe what a test does, given its name. It's also very important for the test to attempt to exercise the same behavior across executions. I'm saying that because I don't think we should fallback to TCG if KVM is not available, but instead, have two different tests that do each a simpler and more predictable set of checks. This would make it simpler to find KVM issues when a given test fails but the TCG continues to pass. The tags (and other mechanisms) can be used to select the tests that a given job should run though. Regards! - Cleber.
