On 2011-05-02 12:33, Alon Levy wrote: > On Mon, May 02, 2011 at 12:25:30PM +0200, Gerd Hoffmann wrote: >> Hi, >> >>> dbg_print takes care of making it standard to have a loglevel and prefix, >>> sounds >>> good, but I'd still like to know if it is acceptable to also redirect with >>> -debug, >>> I guess reusing the DeviceState then, instead of my added struct, so just >>> letting >>> DeviceState.debug_chardev == NULL by default, and settable with >>> -debug<devname>,id=<chardev_id> >> >> Making dbg_print use DeviceState.debug_chardev (if present, stderr >> otherwise) looks sane to me. Buf I'd use standard properties then >> to set it instead of a separate -debug switch, i.e. >> >> -chardev file,id=messages,path=... \ >> -device foo,dbg=1,dbglog=messages >> > > Sounds good. I'll try to make it so.
We have a tracing infrastructure for such use cases today. Better invest in adding missing features there. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
