Patchew URL: https://patchew.org/QEMU/20190628115349.60293-1-...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190628115349.60293-1-...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH 0/4] Introduce the microvm machine type
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
7ea633c hw/i386: Introduce the microvm machine type
df613e2 hw/i386: Add an Intel MPTable generator
a4046b8 hw/virtio: Factorize virtio-mmio headers
6fc3cc5 hw/i386: Factorize CPU routine
=== OUTPUT BEGIN ===
1/4 Checking commit 6fc3cc5db6b1 (hw/i386: Factorize CPU routine)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#102: FILE: hw/i386/cpu.c:47:
+/* Calculates initial APIC ID for a specific CPU index
WARNING: Block comments should align the * on each line
#155: FILE: hw/i386/cpu.c:100:
+ * -smp hasn't been parsed after it
+ */
ERROR: line over 90 characters
#168: FILE: hw/i386/cpu.c:113:
+ ms->possible_cpus->cpus[i].arch_id = cpu_apicid_from_index(i,
compat_apic_id_mode);
WARNING: Block comments use a leading /* on a separate line
#214: FILE: hw/i386/cpu.c:159:
+ /* Calculates the limit to CPU APIC ID values
total: 1 errors, 4 warnings, 438 lines checked
Patch 1/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/4 Checking commit a4046b824588 (hw/virtio: Factorize virtio-mmio headers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#66:
new file mode 100644
total: 0 errors, 1 warnings, 105 lines checked
Patch 2/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/4 Checking commit df613e2dbf51 (hw/i386: Add an Intel MPTable generator)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100644
total: 0 errors, 1 warnings, 376 lines checked
Patch 3/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit 7ea633c1e39e (hw/i386: Introduce the microvm machine type)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60:
new file mode 100644
WARNING: line over 80 characters
#198: FILE: hw/i386/microvm.c:134:
+ object_property_add_child(qdev_get_machine(), "ioapic",
OBJECT(ioapic_dev), NULL);
WARNING: line over 80 characters
#208: FILE: hw/i386/microvm.c:144:
+ mms->gsi = qemu_allocate_irqs(microvm_gsi_handler, ioapic_irq,
IOAPIC_NUM_PINS);
ERROR: consider using qemu_strtol in preference to strtol
#300: FILE: hw/i386/microvm.c:236:
+ index = strtol(separator + 1, NULL, 10);
ERROR: line over 90 characters
#318: FILE: hw/i386/microvm.c:254:
+static void microvm_setup_bootparams(MicrovmMachineState *mms, const gchar
*kernel_cmdline)
WARNING: line over 80 characters
#344: FILE: hw/i386/microvm.c:280:
+ gchar *mmio_cmdline =
microvm_get_virtio_mmio_cmdline(mmio_bus->name);
ERROR: that open brace { should be on the previous line
#414: FILE: hw/i386/microvm.c:350:
+ struct SegmentCache seg_code =
+ { .selector = 0x8, .base = 0x0, .limit = 0xfffff, .flags = 0xa09b00 };
ERROR: that open brace { should be on the previous line
#416: FILE: hw/i386/microvm.c:352:
+ struct SegmentCache seg_data =
+ { .selector = 0x10, .base = 0x0, .limit = 0xfffff, .flags = 0xc09300 };
ERROR: that open brace { should be on the previous line
#418: FILE: hw/i386/microvm.c:354:
+ struct SegmentCache seg_tr =
+ { .selector = 0x18, .base = 0x0, .limit = 0xfffff, .flags = 0x808b00 };
WARNING: Block comments use a leading /* on a separate line
#487: FILE: hw/i386/microvm.c:423:
+ /* Reset APIC after devices have been reset to cancel
ERROR: space prohibited between function name and open parenthesis '('
#567: FILE: hw/i386/microvm.c:503:
+ mc->default_cpu_type = X86_CPU_TYPE_NAME ("host");
total: 6 errors, 5 warnings, 624 lines checked
Patch 4/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190628115349.60293-1-...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
