On Thu, Jun 20, 2019 at 2:30 AM Alistair Francis <alistai...@gmail.com> wrote: > > On Wed, Jun 19, 2019 at 8:18 AM Bin Meng <bmeng...@gmail.com> wrote: > > > > On Wed, Jun 19, 2019 at 1:14 PM Anup Patel <a...@brainfault.org> wrote: > > > > > > On Wed, Jun 19, 2019 at 6:24 AM Alistair Francis > > > <alistair.fran...@wdc.com> wrote: > > > > > > > > Add OpenSBI version 0.3 as a git submodule and as a prebult binary. > > > > > > > > Signed-off-by: Alistair Francis <alistair.fran...@wdc.com> > > > > --- > > > > .gitmodules | 3 +++ > > > > Makefile | 3 ++- > > > > configure | 1 + > > > > pc-bios/opensbi-riscv32-fw_jump.elf | Bin 0 -> 197988 bytes > > > > pc-bios/opensbi-riscv64-fw_jump.elf | Bin 0 -> 200192 bytes > > > > roms/Makefile | 17 +++++++++++++++++ > > > > roms/opensbi | 1 + > > > > 7 files changed, 24 insertions(+), 1 deletion(-) > > > > create mode 100644 pc-bios/opensbi-riscv32-fw_jump.elf > > > > create mode 100644 pc-bios/opensbi-riscv64-fw_jump.elf > > > > create mode 160000 roms/opensbi > > > > > > > > > > The OpenSBI firmwares are platform specific so we should have > > > machine directory under pc-bios/ directory > > > > > > So for virt machine we will have: > > > pc-bios/riscv32/virt/fw_jump.elf > > > pc-bios/riscv64/virt/fw_jump.elf > > I have updated the names to indicate the machine. The pc-bios directly > appears to be flat (at least for binaries) so I don't want to add > subdirectories. >
Should we include pre-built OpenSBI "bios" for "sifive_u" machine too? > > > > And we should only integrate plain binary image for "bios" images here. > > > > pc-bios/riscv32/virt/fw_jump.bin > > pc-bios/riscv64/virt/fw_jump.bin > > Yep, fixed. > Regards, Bin
