On 20.06.19 03:03, John Snow wrote: > This function can claim an hbitmap to replace its own current hbitmap. > In the case that the granularities do not match, it will use > hbitmap_merge to copy the bit data instead.
I really do not like this name because to me it implies a relationship to bdrv_reclaim_dirty_bitmap(). Maybe just bdrv_dirty_bitmap_take()? Or, if you want to get more fancy, bdrv_dirty_dirty_bitmap_steal(). (Because references are taken or stolen.) The latter might fit in nicely with the abdication theme. We’d just need to rename bdrv_reclaim_dirty_bitmap() to bdrv_dirty_bitmap_backstab(), and it’d be perfect. (On another note: bdrv_restore_dirty_bitmap() vs. bdrv_dirty_bitmap_restore() – really? :-/) > Signed-off-by: John Snow <js...@redhat.com> > --- > include/block/block_int.h | 1 + > include/qemu/hbitmap.h | 8 ++++++++ > block/dirty-bitmap.c | 14 ++++++++++++++ > util/hbitmap.c | 5 +++++ > 4 files changed, 28 insertions(+) The implementation looks good to me. Max
signature.asc
Description: OpenPGP digital signature
