Patchew URL: https://patchew.org/QEMU/20190619092905.24029-1-shmuel.eider...@oracle.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface Type: series Message-id: 20190619092905.24029-1-shmuel.eider...@oracle.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190619092905.24029-1-shmuel.eider...@oracle.com -> patchew/20190619092905.24029-1-shmuel.eider...@oracle.com Switched to a new branch 'test' 6664d7d898 hd-geo-test: Add tests for lchs override 29baed3dac bootdevice: FW_CFG interface for LCHS values 2ffcda53e3 bootdevice: Refactor get_boot_devices_list 4bb8461066 bootdevice: Gather LCHS from all relevant devices a7ae6f4985 scsi: Propagate unrealize() callback to scsi-hd 1fc16041c0 bootdevice: Add interface to gather LCHS d9ebbe8309 block: Support providing LCHS from user cf2168a66d block: Refactor macros - fix tabbing === OUTPUT BEGIN === 1/8 Checking commit cf2168a66dbd (block: Refactor macros - fix tabbing) ERROR: Macros with complex values should be enclosed in parenthesis #55: FILE: include/hw/block/block.h:65: +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \ + DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \ + DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \ DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0) total: 1 errors, 0 warnings, 37 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit d9ebbe83096f (block: Support providing LCHS from user) 3/8 Checking commit 1fc16041c029 (bootdevice: Add interface to gather LCHS) 4/8 Checking commit a7ae6f4985e2 (scsi: Propagate unrealize() callback to scsi-hd) 5/8 Checking commit 4bb846106697 (bootdevice: Gather LCHS from all relevant devices) 6/8 Checking commit 2ffcda53e362 (bootdevice: Refactor get_boot_devices_list) 7/8 Checking commit 29baed3dac05 (bootdevice: FW_CFG interface for LCHS values) 8/8 Checking commit 6664d7d898d5 (hd-geo-test: Add tests for lchs override) WARNING: line over 80 characters #242: FILE: tests/hd-geo-test.c:579: + (char *)r->dev_path, &(r->chs.c), &(r->chs.h), &(r->chs.s)); WARNING: Block comments use a leading /* on a separate line #640: FILE: tests/hd-geo-test.c:995: + "skipping hd-geo/override/* tests"); total: 0 errors, 2 warnings, 608 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190619092905.24029-1-shmuel.eider...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
