On 04/27/11 17:05, Luiz Capitulino wrote: > On Mon, 18 Apr 2011 16:27:01 +0200 > jes.soren...@redhat.com wrote: > >> From: Jes Sorensen <jes.soren...@redhat.com> >> >> This is quivalent to snapshot_blkdev in the human monitor, with _sync >> added to the command name to make it explicit that the command is >> synchronous and leave space for a future async version. > > I'm not sure appending "_sync" is such a good convention, most commands > are sync today and they don't have it. I'd prefer to call it snapshot_blkdev > and note in the documentation how it works. > > On the other hand, I'm not sure how Anthony is going to model async > commands, so maybe he has a better suggestion.
The _sync prefix is on purpose to leave space for a possible async implementation of the snapshot command in the future. This isn't related to it being a sync vs async qmp command though. Jes
