On Sun, Apr 03, 2011 at 06:22:45PM +0200, Stefan Weil wrote:
> cppcheck reports this error:
>
> commpage.c:223: error: Possible null pointer dereference:
> value - otherwise it is redundant to check if value is null at line 214
>
> The null pointer check in line 214 is indeed not needed.
> If value were null, the code would crash in line 223.
> See do_compare_and_swap64 were for a reference.
>
> Signed-off-by: Stefan Weil <w...@mail.berlios.de>
> ---
> darwin-user/commpage.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied.
> diff --git a/darwin-user/commpage.c b/darwin-user/commpage.c
> index f6aa71e..cc29bdd 100644
> --- a/darwin-user/commpage.c
> +++ b/darwin-user/commpage.c
> @@ -211,7 +211,7 @@ void do_compare_and_swap32(void *cpu_env, int num)
> uint32_t *value = (uint32_t*)((CPUX86State*)cpu_env)->regs[R_ECX];
> DPRINTF("commpage: compare_and_swap32(%x,new,%p)\n", old, value);
>
> - if(value && old == tswap32(*value))
> + if(old == tswap32(*value))
> {
> uint32_t new = ((CPUX86State*)cpu_env)->regs[R_EDX];
> *value = tswap32(new);
> --
> 1.7.2.5
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurel...@aurel32.net http://www.aurel32.net
